Skip to content

feat: support shift+enter in terminal #19021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

feat: support shift+enter in terminal #19021

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
963f4d0
feat: support shift+enter in terminal
code-asher Jul 23, 2025
77d94ae
Name the escaped carriage return
code-asher Jul 24, 2025
33ac7dc
fmt
code-asher Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Name the escaped carriage return
  • Loading branch information
@code-asher
code-asher committed Jul 24, 2025
commit 77d94ae103802d024dc4f6992888709ec93c3d95
3 changes: 2 additions & 1 deletion site/src/pages/TerminalPage/TerminalPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,12 @@ const TerminalPage: FC = () => {
// typically take this to mean to insert a literal newline. There is no way
// to remove this handler, so we must attach it once and rely on a ref to
// send it to the current socket.
const escapedCarriageReturn = "\x1b\r";
terminal.attachCustomKeyEventHandler((ev) => {
if (ev.shiftKey && ev.key === "Enter") {
if (ev.type === "keydown") {
websocketRef.current?.send(
new TextEncoder().encode(JSON.stringify({ data: "\x1b\r" })),
new TextEncoder().encode(JSON.stringify({ data: escapedCarriageReturn })),
);
}
return false;
Expand Down
Loading