chore: add usage tracking package #19095
Open
+2,038
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
johnstcn
reviewed
Jul 30, 2025
enterprise/coderd/usage/publisher.go
Outdated
| const ( | ||
| CoderLicenseJWTHeader = "Coder-License-JWT" | ||
|
|
||
| tallymanURL = "https://tallyman-ingress.coder.com" |
There was a problem hiding this comment.
I can see an argument for making this a var so it's configurable at build time.
There was a problem hiding this comment.
If we do need that we can add it very easily in the future.
There was a problem hiding this comment.
Obligatory reminder to check migration number before merging!
spikecurtis
reviewed
Jul 30, 2025
coderd/database/migrations/000353_create_usage_events_table.up.sql
Outdated
Show resolved
Hide resolved
coderd/database/migrations/000353_create_usage_events_table.up.sql
Outdated
Show resolved
Hide resolved
e376311 to
82ea8e1
Compare
johnstcn
approved these changes
Aug 15, 2025
Comment on lines
+52
to
+55
| jsonData, err := json.Marshal(event.Fields()) | ||
| if err != nil { | ||
| return xerrors.Errorf("marshal event as JSON: %w", err) | ||
| } |
There was a problem hiding this comment.
Might be worth adding a test case for an un-marshalable event
Comment on lines
+631
to
+636
| func jsoninate(t *testing.T, v any) string { | ||
| t.Helper() | ||
| buf, err := json.Marshal(v) | ||
| require.NoError(t, err) | ||
| return string(buf) | ||
| } |
There was a problem hiding this comment.
suggestion, non-blocking: could be useful as testutil.MustJSON
spikecurtis
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not used in coderd yet, see stack.
Adds two new packages:
coderd/usage: provides an interface for the "Collector" as well as a stub implementation for AGPLenterprise/coderd/usage: provides an interface for the "Publisher" as well as a Tallyman implementationRelates to coder/internal#814