Skip to content

feat: add user_secrets table #19162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 7, 2025
Merged

feat: add user_secrets table #19162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
104bf21
feat: add user_secrets table
evgeniy-scherbina Aug 4, 2025
b677273
feat: add SQL queries
evgeniy-scherbina Aug 4, 2025
a826dd3
feat: add DBAuthz wrappers and UserSecret resource type
evgeniy-scherbina Aug 5, 2025
540f2e2
feat: add DBAuthz tests
evgeniy-scherbina Aug 5, 2025
363173c
test: fix role-permissions test
evgeniy-scherbina Aug 5, 2025
e152648
test: fix migration test
evgeniy-scherbina Aug 5, 2025
49ac807
fix: change user-secret permissions
evgeniy-scherbina Aug 5, 2025
85b4f4c
fix: add unit-tests for sql queries
evgeniy-scherbina Aug 6, 2025
3f04a15
test: improve unit-tests for sql queries
evgeniy-scherbina Aug 6, 2025
d7605f6
refactor: use table-test approach for secrets-authz test
evgeniy-scherbina Aug 6, 2025
b55be78
refactor: minor refactor in tests
evgeniy-scherbina Aug 6, 2025
3090d52
fix: formatting
evgeniy-scherbina Aug 6, 2025
789a5eb
fix: formatting
evgeniy-scherbina Aug 6, 2025
12b6c2e
ci: run make gen and make fmt
evgeniy-scherbina Aug 6, 2025
317708b
refactor: CR's fixes
evgeniy-scherbina Aug 7, 2025
72faf7a
Update coderd/database/dbauthz/dbauthz.go
evgeniy-scherbina Aug 7, 2025
a715310
Update coderd/database/dbauthz/dbauthz.go
evgeniy-scherbina Aug 7, 2025
8ea3cda
refactor: CR's fixes
evgeniy-scherbina Aug 7, 2025
b21f07c
refactor: CR's fixes
evgeniy-scherbina Aug 7, 2025
0f47bae
refactor: CR's fixes
evgeniy-scherbina Aug 7, 2025
1d6f2fa
refactor: CR's fixes
evgeniy-scherbina Aug 7, 2025
b24599c
Merge remote-tracking branch 'origin/main' into yevhenii/secrets-db-s…
evgeniy-scherbina Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci: run make gen and make fmt
  • Loading branch information
@evgeniy-scherbina
evgeniy-scherbina committed Aug 6, 2025
commit 12b6c2ee3ad0b6d261c32297751ddd25f1522257
2 changes: 1 addition & 1 deletion coderd/database/queries.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion coderd/rbac/roles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ func ReloadBuiltinRoles(opts *RoleOptions) {
// Note: even without PrebuiltWorkspace permissions, access is still granted via Workspace permissions.
ResourcePrebuiltWorkspace.Type: {policy.ActionUpdate, policy.ActionDelete},
})...),
Org: map[string][]Permission{},
Org: map[string][]Permission{},
User: Permissions(map[string][]policy.Action{
// Users should be able to access their own secrets.
ResourceUserSecret.Type: {policy.ActionRead, policy.ActionCreate, policy.ActionUpdate, policy.ActionDelete},
Expand Down
Loading