Skip to content

chore(codersdk/workspacesdk): make dialer fail fast for authnz errors #19173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

chore(codersdk/workspacesdk): make dialer fail fast for authnz errors #19173

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72b8701
chore: make workspace sdk dialer fail fast for authnz errors
ethanndickson Aug 5, 2025
b5a1cd6
review
ethanndickson Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review
  • Loading branch information
@ethanndickson
ethanndickson committed Aug 5, 2025
commit b5a1cd6a670d5d59c45f36b2d40a8c8472ea9b9f
4 changes: 3 additions & 1 deletion codersdk/workspacesdk/dialer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ var permanentErrorStatuses = []int{
http.StatusBadRequest, // returned if API mismatch
http.StatusNotFound, // returned if user doesn't have permission or agent doesn't exist
http.StatusInternalServerError, // returned if database is not reachable,
http.StatusUnauthorized, // returned if user is not authenticated
http.StatusForbidden, // returned if user is not authorized
// StatusUnauthorized is only a permanent error if the error is not due to
// an invalid resume token. See `checkResumeTokenFailure`.
http.StatusUnauthorized,
}

type WebsocketDialer struct {
Expand Down
Loading