Skip to content

fix: fix incorrect migration in constraint #19212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

fix: fix incorrect migration in constraint #19212

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2178ef
hotfix: fix incorrect migration in constraint
deansheather Aug 7, 2025
cd70fd1
add timestamptz
deansheather Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion coderd/database/migrations/000356_enforce_deadline_below_max_deadline.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ UPDATE
SET
deadline = max_deadline
WHERE
deadline > max_deadline
(deadline = '0001-01-01 00:00:00+00' OR deadline > max_deadline)
AND max_deadline != '0001-01-01 00:00:00+00';

-- Add the new constraint.
ALTER TABLE workspace_builds
ADD CONSTRAINT workspace_builds_deadline_below_max_deadline
CHECK (
-- (deadline is not zero AND deadline <= max_deadline)...
(deadline != '0001-01-01 00:00:00+00'::timestamptz AND deadline <= max_deadline)
-- UNLESS max_deadline is zero.
OR max_deadline = '0001-01-01 00:00:00+00'::timestamptz
);
Loading