Skip to content

chore: improve message when running develop.sh multiple times #19333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025

Conversation

johnstcn
Copy link
Member

develop.sh checks for existing processes listening on port 3000 or 8080.
We can check if it's the development server to avoid confusion.

@johnstcn johnstcn self-assigned this Aug 13, 2025
Copy link
Contributor

@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Tested with ./scripts/develop.sh running and it worked well. Also tested with python3 -m http.server 8080 and python3 -m http.server 3000 and worked for both.

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a minor cleanup, otherwise LGTM!

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@johnstcn johnstcn merged commit f17ab92 into main Aug 13, 2025
31 checks passed
@johnstcn johnstcn deleted the cj/develop-sh-running-check branch August 13, 2025 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2025
@johnstcn
Copy link
Member Author

This should help with part of coder/internal#854

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants