chore: set editorconfig to use spaces instead of tabs for sql files #19344
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
reviewed
Aug 14, 2025
| @@ -18,3 +18,7 @@ indent_size = 2 | |||
| [coderd/database/dump.sql] | |||
| indent_style = space | |||
| indent_size = 4 | |||
|
|
|||
| [coderd/database/queries/*.sql] | |||
There was a problem hiding this comment.
Suggested change
| [coderd/database/queries/*.sql] | |
| [*.sql] |
it'd be nice if everything was included. we could reformat migrations, or at least format them going forward. with all of the views we have that need to be recreated when you edit an underlying table stuff ends up getting copied and pasted around a lot.
There was a problem hiding this comment.
The one I was avoiding was dump.sql which is generated by pg_dump and uses spaces. I don't want an editor config formatter to cause diffs in an autogenerated file.
I can extend this to migrations
aslilac
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use spaces consistently in
*.sqlfilesEvery file needs to be corrected 😢
Not going to do that in this PR