Skip to content

ci: add paralleltestctx to lint/go #19369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Aug 15, 2025

Closes coder/internal#884

We're adding this as a go run in lint/go for now, since adding it to golangci-lint ourselves involves recompiling golangci-lint and then running that new binary. I'll look into proposing it being added to the public golangci-lint linters.

Doesn't appear to cause the lint ci job to take any longer, which is nice.

This first pass of the linter picked up 10 issues! 🎉

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson force-pushed the ethan/add-paralleltestctx branch from 4b5b88a to 61c2939 Compare August 15, 2025 05:51
@ethanndickson ethanndickson marked this pull request as ready for review August 15, 2025 06:03
@ethanndickson ethanndickson changed the title ci: add paralleltestctx to lint/go ci: add paralleltestctx to lint/go Aug 15, 2025
@ethanndickson ethanndickson merged commit d7bdb3c into main Aug 15, 2025
41 of 42 checks passed
@ethanndickson ethanndickson deleted the ethan/add-paralleltestctx branch August 15, 2025 06:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a linter to detect usage of contexts with timeouts from parent tests in subtests that call t.Parallel
2 participants