Add Rustdesk module #266

BenraouaneSoufiane · 2025-07-30T11:50:37Z

Closes #79

Description

This PR add new module, install minimal desktop environment (xfce), virtual display, ,rustdesk package from deb file, init new screen, export DISPLAY environment variable with last created virtual screen, start new xfce session & execute the rustdesk cli, generate new password, change the default password, then log the ID & password to be used within rustdesk client to connect to the host

Type of Change

Module Information

Overview/test video: live demo that launch rustdesk with GUI in a docker container https://youtu.be/_rR-l7nARN4
Screenshots:

Path: registry/BenraouaneSoufiane/modules/rustdesk
New version: v1.0.0
Breaking change: [ ] Yes [x] No

Testing & Validation

Tests pass (bun test)
Code formatted (bun run fmt)
Changes tested locally

Related Issues

/claim #79 (remain asset 150$)

BenraouaneSoufiane · 2025-07-30T16:41:01Z

@matifali can you release the pending asset (150$)?

DevelopmentCats · 2025-07-31T00:18:49Z

@matifali can you release the pending asset (150$)?

This is released automatically once the PR is merged and closed

BenraouaneSoufiane · 2025-07-31T07:58:43Z

@matifali can you release the pending asset (150$)?

This is released automatically once the PR is merged and closed

No comment! But why I'm being delayed as this PR resolve the issue?

DevelopmentCats · 2025-07-31T16:56:28Z

@matifali can you release the pending asset (150$)?

This is released automatically once the PR is merged and closed

No comment! But why I'm being delayed as this PR resolve the issue?

There is no intentional delay, as Algora releases the bounty once the PR is approved, and merged.

This is outlined in the Coder Bounty Issue #213

registry/BenraouaneSoufiane/modules/rustdesk/main.tf

registry/BenraouaneSoufiane/modules/rustdesk/README.md

registry/BenraouaneSoufiane/modules/rustdesk/run.sh

RustDesk.toml

rustdesk-1.1.9.deb

DevelopmentCats · 2025-08-13T14:34:23Z

@BenraouaneSoufiane Just checking if there is any update on this?

BenraouaneSoufiane · 2025-08-13T17:36:51Z

@BenraouaneSoufiane Just checking if there is any update on this?

Fixed, thank you!

Copilot

Pull Request Overview

This PR introduces a new RustDesk module that enables remote desktop access within Coder workspaces. The module automates the installation of RustDesk, sets up a virtual display using Xvfb, and provides connection credentials for remote access.

Key changes:

Adds a complete RustDesk module with cross-platform package manager support
Implements automatic password generation and virtual display configuration
Provides Terraform integration with configurable parameters

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.

File	Description
`registry/BenraouaneSoufiane/modules/rustdesk/run.sh`	Main installation and setup script with package manager detection and RustDesk configuration
`registry/BenraouaneSoufiane/modules/rustdesk/main.tf`	Terraform module definition with variables and Coder resource configuration
`registry/BenraouaneSoufiane/modules/rustdesk/README.md`	Module documentation with usage instructions and configuration examples
`registry/BenraouaneSoufiane/README.md`	Author profile information

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

registry/BenraouaneSoufiane/modules/rustdesk/README.md

registry/BenraouaneSoufiane/modules/rustdesk/main.tf

registry/BenraouaneSoufiane/modules/rustdesk/run.sh

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

BenraouaneSoufiane · 2025-08-13T20:27:38Z

@DevelopmentCats thank you for your suggestions, I've committed the suggested fixes

Tell users how to use/customize the module like rustdesk version, virtual screen dimentions & the password

DevelopmentCats · 2025-08-14T01:47:16Z

@BenraouaneSoufiane Can you run bun run fmt on this? @BenraouaneSoufiane

BenraouaneSoufiane · 2025-08-14T08:31:01Z

Can you run bun run fmt on this? @BenraouaneSoufiane

Formatted, thank you

DevelopmentCats · 2025-08-14T15:22:05Z

Can you run bun run fmt on this? @BenraouaneSoufiane

Formatted, thank you

@BenraouaneSoufiane Can you remove the package-lock file you accidentally left in the commit?

BenraouaneSoufiane · 2025-08-14T15:24:47Z

Can you run bun run fmt on this? @BenraouaneSoufiane

Formatted, thank you

@BenraouaneSoufiane Can you remove the package-lock file you accidentally left in the commit?

Sorry for that, it were deleted now, thanks

DevelopmentCats · 2025-08-14T19:32:54Z

Run bun fmt:ci
  bun fmt:ci
  shell: /usr/bin/bash -e {0}
$ bun x prettier --check **/*.sh **/*.ts **/*.md *.md && terraform fmt -check -recursive -diff
Checking formatting...
[warn] registry/BenraouaneSoufiane/modules/rustdesk/README.md
[warn] Code style issues found in the above file. Run Prettier with --write to fix.
error: script "fmt:ci" exited with code 1
Error: Process completed with exit code 1.

@BenraouaneSoufiane

BenraouaneSoufiane · 2025-08-14T20:07:16Z

Run bun fmt:ci
  bun fmt:ci
  shell: /usr/bin/bash -e {0}
$ bun x prettier --check **/*.sh **/*.ts **/*.md *.md && terraform fmt -check -recursive -diff
Checking formatting...
[warn] registry/BenraouaneSoufiane/modules/rustdesk/README.md
[warn] Code style issues found in the above file. Run Prettier with --write to fix.
error: script "fmt:ci" exited with code 1
Error: Process completed with exit code 1.

@BenraouaneSoufiane

I think it's related with terraform (not found, even it's installed), all things related with prettier are succeed, so I run terraform fmt command manually with the recursive flag of course which format well my main.tf, the same thing with run.sh, I run shfmt -w path/to/run.sh which format the script, you see the differences

BenraouaneSoufiane · 2025-08-14T20:22:34Z

I was thinking it may an issue with run.sh after using external formatter, I just did a quick review using online shell validator
The same thing with terraform script (main.tf)
It's probably doesn't related with my contribution at all, I don't know what to do even I come to my room

cc: @DevelopmentCats

…dcoded version. Fix loging so that it will actually output to workspace logs.

…fy virtual display setup

…lation

BenraouaneSoufiane

@DevelopmentCats Everything looks good, but still couldn't figure out what are changes requested by you

BenraouaneSoufiane · 2025-08-15T08:06:45Z

@DevelopmentCats I got changes requested but i couldn't see them, can you outline them?

root and others added 8 commits July 24, 2025 19:11

Add Rustdesk module

59c2932

Update README.md

eef8b83

Update README.md

1a53794

Delete registry/benraouanesoufiane directory

89bd112

Update README.md

3632017

Merge branch 'coder:main' into main

66854ab

Fix mentionned issues

03c06e6

Moving module to BenraouaneSoufiane & updating readme.md

2f593bb

algora-pbc bot added the 🙋 Bounty claim label Jul 30, 2025

Merge branch 'coder:main' into main

1b285fb

DevelopmentCats requested changes Aug 8, 2025

View reviewed changes

DevelopmentCats reviewed Aug 8, 2025

View reviewed changes

rustdesk-1.1.9.deb Outdated Show resolved Hide resolved

DevelopmentCats and others added 9 commits August 13, 2025 09:34

Merge branch 'main' into main

b1210b7

Delete rustdesk-1.1.9.deb

8d198a2

Delete rustdesk-1.1.9.deb.1

e0521fc

Delete rustdesk-1.4.0-x86_64.deb

c7124c9

Delete rustdesk-1.4.0-x86_64.deb.1

79cc39e

Delete rustdesk-1.4.0-x86_64.deb.2

d20b0f0

Delete rustdesk-1.4.0-x86_64.deb.3

832981c

Fix outlined issues

918f79b

Merge branch 'coder:main' into main

ba840b7

Delete RustDesk.toml

d917244

DevelopmentCats requested a review from Copilot August 13, 2025 20:21

Copilot AI reviewed Aug 13, 2025

View reviewed changes

BenraouaneSoufiane and others added 4 commits August 13, 2025 21:25

Update registry/BenraouaneSoufiane/modules/rustdesk/README.md

01f93a3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update registry/BenraouaneSoufiane/modules/rustdesk/main.tf

3b11a27

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update registry/BenraouaneSoufiane/modules/rustdesk/run.sh

97330a6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update registry/BenraouaneSoufiane/modules/rustdesk/run.sh

b889cff

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

BenraouaneSoufiane added 2 commits August 13, 2025 21:54

Merge branch 'coder:main' into main

15a734e

Update README.md

fb3ee63

Tell users how to use/customize the module like rustdesk version, virtual screen dimentions & the password

Formatting files using fmt command

a8a2a75

Delete package-lock.json

6ebd45b

DevelopmentCats added 11 commits August 14, 2025 19:48

chore: run bun run fmt

1c97157

chore: update avatar_url to avatar

17ee696

chore: restructure and clean up README

2349eba

chore: bun run fmt

608a411

chore: update examples

b20615d

fix: change default version to latest unless specified instead of har…

f5ca292

…dcoded version. Fix loging so that it will actually output to workspace logs.

fix: use sudo instead of requiring root

2c94a68

chore: bun run fmt

0797881

fix: add LOG_PATH

a777679

fix: update README and run script to remove XFCE dependency and clari…

6a386b2

…fy virtual display setup

fix: add xkb-data and xkeyboard-config dependencies for proper instal…

97f6571

…lation

BenraouaneSoufiane commented Aug 15, 2025

View reviewed changes

BenraouaneSoufiane requested a review from DevelopmentCats August 15, 2025 04:49

Add Rustdesk module #266

Are you sure you want to change the base?

Add Rustdesk module #266

Conversation

BenraouaneSoufiane commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Module Information

Testing & Validation

Related Issues

Uh oh!

BenraouaneSoufiane commented Jul 30, 2025

Uh oh!

DevelopmentCats commented Jul 31, 2025

Uh oh!

BenraouaneSoufiane commented Jul 31, 2025

Uh oh!

DevelopmentCats commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DevelopmentCats commented Aug 13, 2025

Uh oh!

BenraouaneSoufiane commented Aug 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenraouaneSoufiane commented Aug 13, 2025

Uh oh!

DevelopmentCats commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenraouaneSoufiane commented Aug 14, 2025

Uh oh!

DevelopmentCats commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenraouaneSoufiane commented Aug 14, 2025

Uh oh!

DevelopmentCats commented Aug 14, 2025

Uh oh!

BenraouaneSoufiane commented Aug 14, 2025

Uh oh!

BenraouaneSoufiane commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenraouaneSoufiane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenraouaneSoufiane commented Aug 15, 2025

Uh oh!

Uh oh!

BenraouaneSoufiane commented Jul 30, 2025 •

edited

Loading

DevelopmentCats commented Aug 14, 2025 •

edited

Loading

DevelopmentCats commented Aug 14, 2025 •

edited

Loading

BenraouaneSoufiane commented Aug 14, 2025 •

edited

Loading

BenraouaneSoufiane left a comment •

edited

Loading