Mark pattern matcher synthetics as SYNTHETIC.

paulp · paulp · commit 3177934fc157 · 2012-11-24T01:43:23.000-08:00
Flagging synthetics accurately is important to allow for
useful static analysis.
diff --git a/src/compiler/scala/tools/nsc/transform/UnCurry.scala b/src/compiler/scala/tools/nsc/transform/UnCurry.scala
@@ -369,7 +369,7 @@ abstract class UnCurry extends InfoTransform
       }
 
       val isDefinedAtMethodDef = {
-        val methSym = anonClass.newMethod(nme.isDefinedAt, fun.pos, FINAL)
+        val methSym = anonClass.newMethod(nme.isDefinedAt, fun.pos, FINAL | SYNTHETIC)
         val params  = methSym newSyntheticValueParams formals
         methSym setInfoAndEnter MethodType(params, BooleanClass.tpe)
 
diff --git a/src/compiler/scala/tools/nsc/typechecker/PatternMatching.scala b/src/compiler/scala/tools/nsc/typechecker/PatternMatching.scala
@@ -1405,7 +1405,7 @@ trait PatternMatching extends Transform with TypingTransformers with ast.TreeDSL
 
     // assert(owner ne null); assert(owner ne NoSymbol)
     def freshSym(pos: Position, tp: Type = NoType, prefix: String = "x") =
-      NoSymbol.newTermSymbol(freshName(prefix), pos) setInfo tp
+      NoSymbol.newTermSymbol(freshName(prefix), pos, newFlags = SYNTHETIC) setInfo tp
 
     def newSynthCaseLabel(name: String) =
       NoSymbol.newLabel(freshName(name), NoPosition) setFlag treeInfo.SYNTH_CASE_FLAGS

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ abstract class UnCurry extends InfoTransform`
`369`	`369`	`}`
`370`	`370`
`371`	`371`	`val isDefinedAtMethodDef = {`
`372`		`- val methSym = anonClass.newMethod(nme.isDefinedAt, fun.pos, FINAL)`
	`372`	`+ val methSym = anonClass.newMethod(nme.isDefinedAt, fun.pos, FINAL \| SYNTHETIC)`
`373`	`373`	`val params = methSym newSyntheticValueParams formals`
`374`	`374`	`methSym setInfoAndEnter MethodType(params, BooleanClass.tpe)`
`375`	`375`