Skip to content

Remove python 3.7 and 3.8 from test matrix. #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

Remove python 3.7 and 3.8 from test matrix. #724

merged 1 commit into from
Jun 9, 2025

Conversation

surister
Copy link
Contributor

@surister surister commented Jun 9, 2025 •
edited
Loading

As you may know, both 3.7 and 3.8 are EOL, they receive no support/security fixes, nothing.

For that reason I would propose to remove them from the test matrix, we are also seeing new dependencies updates fail on 3.7, because of the libraries using >3.7 syntax (walrus operator), an example of this is https://github.com/crate/crate-python/actions/runs/15392143903/job/43303839083

We previously had a discussion on whether or not to keep 3.8 at crate/cratedb-sqlparse#173

Summary of the changes / Why this is an improvement

  • Title

@surister
Remove python 3.7 and 3.8 from test matrix.
141362d 
As you may know, both 3.7 and 3.8 are EOL, they receive no support/security fixes, nothing.

For that reason I would remove them from the test matrix, we are also seeing new dependencies updates fail on 3.7, because of the libraries using >3.7 syntax (walrus operator), an example of this is https://github.com/crate/crate-python/actions/runs/15392143903/job/43303839083
@surister surister requested a review from amotl June 9, 2025 16:26
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 9, 2025 •
edited
Loading

Walkthrough

The GitHub Actions workflow configuration was updated to remove Python 3.7 and 3.8 from the test matrix for Ubuntu 22.04. The workflow now tests only Python 3.9 through 3.13 on Ubuntu, while other aspects of the workflow remain unchanged.

Changes

File(s) Change Summary
.github/workflows/tests.yml Removed Python 3.7 and 3.8 from Ubuntu test matrix; now tests Python 3.9–3.13 only

Poem

In the garden of code where our tests bloom bright,
Two old pythons hopped softly out of sight.
Now newer snakes slither, swift and lean,
On Ubuntu fields, their scales all clean.
The rabbit cheers, “Let the tests run right!” 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb4d70d and 141362d.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: Python: 3.13 on macos-latest
  • GitHub Check: Python: 3.12 on macos-latest
  • GitHub Check: Python: 3.11 on macos-latest
  • GitHub Check: Python: 3.13 on ubuntu-22.04
  • GitHub Check: Python: 3.12 on ubuntu-22.04
  • GitHub Check: Python: 3.11 on ubuntu-22.04
  • GitHub Check: Python: 3.10 on ubuntu-22.04
  • GitHub Check: Python: 3.9 on ubuntu-22.04
  • GitHub Check: Run link checker
🔇 Additional comments (1)
.github/workflows/tests.yml (1)

22-22: Remove EOL Python 3.7 and 3.8 from Ubuntu test matrix
Testing now focuses on supported versions 3.9–3.13, which aligns with the EOL status of 3.7/3.8.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@surister surister requested a review from seut June 9, 2025 16:26
@amotl
Copy link
Member

amotl commented Jun 9, 2025 •
edited
Loading

We previously had a discussion on whether or not to keep 3.8 at crate/cratedb-sqlparse#173.

To clarify, I would like to retain compatibility through package metadata, when applicable and given, even when dropping validation on CI, if it works and if it's reasonably responsible. 🍀

@amotl amotl merged commit b143f1c into main Jun 9, 2025
17 checks passed
@amotl amotl deleted the remove-old-python branch June 9, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl approved these changes

@seut seut Awaiting requested review from seut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surister @amotl