Skip to content

TST: fix cupy to_device test on multiple devices #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025
Merged

TST: fix cupy to_device test on multiple devices #326

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c3d68c
TST: fix cupy `to_device` test on multiple devices
crusaderky May 15, 2025
c829ef7
nits
crusaderky May 15, 2025
0433b8e
skip segmentation fault
crusaderky May 15, 2025
ebd3fd9
Use pointers
crusaderky May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 34 additions & 11 deletions tests/test_cupy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,41 @@
from cupy.cuda import Stream


def test_to_device_with_stream():
@pytest.mark.parametrize(
"make_stream",
[
lambda: Stream(),
lambda: Stream(non_blocking=True),
lambda: Stream(null=True),
lambda: Stream(ptds=True),
],
)
def test_to_device_with_stream(make_stream):
devices = xp.__array_namespace_info__().devices()
streams = [
Stream(),
Stream(non_blocking=True),
Stream(null=True),
Stream(ptds=True),
123, # dlpack stream
]

a = xp.asarray([1, 2, 3])
for dev in devices:
for stream in streams:
b = to_device(a, dev, stream=stream)
assert device(b) == dev
# Streams are device-specific and must be created within
# the context of the device...
with dev:
stream = make_stream()
# ... however, to_device() does not need to be inside the
# device context.
b = to_device(a, dev, stream=stream)
assert device(b) == dev


def test_to_device_with_dlpack_stream():
devices = xp.__array_namespace_info__().devices()

a = xp.asarray([1, 2, 3])
for dev in devices:
# Streams are device-specific and must be created within
# the context of the device...
with dev:
s1 = Stream()

# ... however, to_device() does not need to be inside the
# device context.
b = to_device(a, dev, stream=s1.ptr)
assert device(b) == dev
Loading