-
-
Notifications
You must be signed in to change notification settings - Fork 247
Implement attribute helper #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
valzargaming
wants to merge
24
commits into
master
Choose a base branch
from
implement-attribute-helper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors numerous attribute getter methods across the codebase to use a new helper method,
attributeHelper
, forPart
creation and attribute access. This change improves code consistency, reduces duplication, and makes it easier to manage extra data passed to constructors. The update also modifies the implementation ofattributeHelper
inPartTrait
to support additional data merging for object instantiation.Refactoring attribute getters to use
attributeHelper
:Channel
,Message
,Invite
,Reaction
,Button
,Action
,Activity
,Collectibles
,Member
,User
, etc.) with calls to the newattributeHelper
method, streamlining the logic and reducing repetitive code. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30]Enhancements to
attributeHelper
:attributeHelper
method inPartTrait
to accept an optionalextraData
array, which is merged into the attributes when creating new objects, allowing for more flexible and context-aware instantiation.This refactor will make future maintenance easier and help ensure that attribute access and object creation remain consistent throughout the codebase.