Skip to content

feat(builders)!: Support select in modals #11034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(builders)!: Support select in modals #11034

wants to merge 13 commits into from

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Aug 7, 2025 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Aug 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Aug 30, 2025 1:58pm
discord-js-guide Ignored Ignored Preview Aug 30, 2025 1:58pm

@Jiralite Jiralite added this to the builders 2.0.0 milestone Aug 7, 2025
Qjuh
Qjuh previously requested changes Aug 7, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Aug 7, 2025
vladfrangu
vladfrangu previously requested changes Aug 7, 2025
View reviewed changes
@Jiralite Jiralite changed the title feat: Support select in modals feat!: Support select in modals Aug 8, 2025
@Jiralite Jiralite dismissed stale reviews from vladfrangu and Qjuh August 8, 2025 10:27

Resolved.

vladfrangu
vladfrangu previously requested changes Aug 29, 2025
View reviewed changes
@Jiralite Jiralite force-pushed the feat/select-in-modals branch from e11c828 to f95cfe5 Compare August 29, 2025 10:37
@Jiralite Jiralite marked this pull request as ready for review August 29, 2025 12:03
@Jiralite Jiralite requested a review from a team as a code owner August 29, 2025 12:03
@vladfrangu vladfrangu changed the title feat!: Support select in modals feat(builders)!: Support select in modals Aug 30, 2025
vladfrangu
vladfrangu previously requested changes Aug 30, 2025
View reviewed changes
@Jiralite Jiralite requested a review from vladfrangu August 30, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qjuh Qjuh Qjuh left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/builders

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/builders

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/builders

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
api support packages:builders semver:major
Projects
discord.js
Status: Review in Progress
Milestone
builders 2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiralite @vladfrangu @Qjuh