feat(rest): callbacks for timeout and retry backoff #11067
+263
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11067 +/- ##
==========================================
+ Coverage 44.06% 44.19% +0.12%
==========================================
Files 310 310
Lines 17755 17816 +61
Branches 1755 1772 +17
==========================================
+ Hits 7824 7874 +50
- Misses 9919 9930 +11
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qjuh
reviewed
Aug 29, 2025
Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com>
|
Does this address #11000? |
|
No, not at all. That requires a change in discord.js not rest (which I'll get to later today) |
kyranet
previously requested changes
Sep 2, 2025
didinele
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds two related utility options for managing rest requests more dynamically.
Retry Backoff is completely new, allows backing off on 5xx and aborted requests. Closes: #10571
timeout gets a callback utility, allows setting the timeout per request Closes: #10927 and supersedes #11013
Status and versioning classification: