Skip to content

UX: fast topic edit #32941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025
Merged

UX: fast topic edit #32941

merged 5 commits into from
Jun 3, 2025

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented May 27, 2025

Changes of this commit:

  • edit pencil will only show on hover on desktop
  • clicking the topic title will display the topic edit UI
Kapture.2025-06-03.at.11.32.23.mp4

/t/-/154792

Changes of this commit:
- edit pencil will only show on hover on desktop
- clicking the topic title will display the topic edit UI

/t/-/141827
@jjaffeux jjaffeux force-pushed the edit-topic-hover-desktop branch from 5d8716e to ee0a94b Compare June 3, 2025 09:30
@jjaffeux jjaffeux changed the title UX: show edit topic button on hover only on desktop UX: fast topic edit Jun 3, 2025
@jjaffeux
Copy link
Contributor Author

jjaffeux commented Jun 3, 2025

discourse-ai spec failure is fixed in: discourse/discourse-ai#1394

Copy link
Contributor

@Grubba27 Grubba27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make sense to have a spec for the click-show-edit-ui part?

@jjaffeux
Copy link
Contributor Author

jjaffeux commented Jun 3, 2025

Would make sense to have a spec for the click-show-edit-ui part?

we already do given it's the only way, the existing specs are doing this

jjaffeux added a commit to discourse/discourse-ai that referenced this pull request Jun 3, 2025
@jjaffeux jjaffeux merged commit 6e00357 into main Jun 3, 2025
15 of 16 checks passed
@jjaffeux jjaffeux deleted the edit-topic-hover-desktop branch June 3, 2025 14:30
romanrizzi pushed a commit to discourse/discourse-ai that referenced this pull request Jun 3, 2025
megothss pushed a commit that referenced this pull request Jun 3, 2025
Changes of this commit:
- edit pencil will only show on hover on desktop
- clicking the topic title will display the topic edit UI

https://github.com/user-attachments/assets/58c55351-96ed-4f2d-8bd6-569310901cf0

/t/-/154792
martin-brennan pushed a commit that referenced this pull request Jun 10, 2025
Changes of this commit:
- edit pencil will only show on hover on desktop
- clicking the topic title will display the topic edit UI

https://github.com/user-attachments/assets/58c55351-96ed-4f2d-8bd6-569310901cf0

/t/-/154792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants