-
Notifications
You must be signed in to change notification settings - Fork 8.6k
UX: fast topic edit #32941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
UX: fast topic edit #32941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes of this commit: - edit pencil will only show on hover on desktop - clicking the topic title will display the topic edit UI /t/-/141827
5d8716e
to
ee0a94b
Compare
jjaffeux
added a commit
to discourse/discourse-ai
that referenced
this pull request
Jun 3, 2025
discourse-ai spec failure is fixed in: discourse/discourse-ai#1394 |
Grubba27
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make sense to have a spec for the click-show-edit-ui part?
we already do given it's the only way, the existing specs are doing this |
jjaffeux
added a commit
to discourse/discourse-ai
that referenced
this pull request
Jun 3, 2025
romanrizzi
pushed a commit
to discourse/discourse-ai
that referenced
this pull request
Jun 3, 2025
megothss
pushed a commit
that referenced
this pull request
Jun 3, 2025
Changes of this commit: - edit pencil will only show on hover on desktop - clicking the topic title will display the topic edit UI https://github.com/user-attachments/assets/58c55351-96ed-4f2d-8bd6-569310901cf0 /t/-/154792
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
Changes of this commit: - edit pencil will only show on hover on desktop - clicking the topic title will display the topic edit UI https://github.com/user-attachments/assets/58c55351-96ed-4f2d-8bd6-569310901cf0 /t/-/154792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes of this commit:
Kapture.2025-06-03.at.11.32.23.mp4
/t/-/154792