UX: Add subheader to admin themes page #32987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffae81c to
3a6968d
Compare
|
@Drenmi The frontend test failure is legit. Given we already have a system test for this, I wonder if we need to keep the frontend acceptance tests around. |
tgxworld
reviewed
May 29, 2025
app/assets/javascripts/admin/addon/components/admin-config-areas/themes.gjs
Outdated
Show resolved
Hide resolved
3a6968d to
ab47e1a
Compare
I was about to remove them, but I decided to update them to click the new button instead, because they are more comprehensive than the system test for now. |
ab47e1a to
f632857
Compare
tgxworld
approved these changes
May 29, 2025
tgxworld
reviewed
May 29, 2025
f632857 to
be1906a
Compare
be1906a to
abc74d3
Compare
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
Add subheader with install button to match the Components tab. Remove the "special" card with the install button from the end of the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Screenshot: