-
Notifications
You must be signed in to change notification settings - Fork 8.6k
FEATURE: Add post language on creating a new post #33001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
approved these changes
Jun 11, 2025
keegangeorge
added a commit
that referenced
this pull request
Jun 11, 2025
This reverts commit b55af38.
keegangeorge
added a commit
that referenced
this pull request
Jun 11, 2025
davidtaylorhq
added a commit
that referenced
this pull request
Jun 11, 2025
keegangeorge
added a commit
that referenced
this pull request
Jun 11, 2025
This is a second attempt at: #33001 We had to [revert the commit](#33157) because it was performing a site-setting check at boot time, which is prone to issues and not allowed. This PR: - re-introduces the changes in the original PR - a fix by not performing a site-setting check at boot time (verified by: `SKIP_DB_AND_REDIS=1 DISCOURSE_DEV_DB="nonexist" bin/rails runner "puts 'booted'"` locally and should be caught by the new CI check introduced here: #33158) - adds a fix to the translation editor to not show the original post locale in the dropdown, as well as adding an indicator of what the original post locale is in a small badge in the header: - 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
Previously we added the ability to translate existing posts in different languages: #32564. In this update we add the ability to set a post language upon initially creating a post.
Internally, we also clean-up/improve a few things, like:
PostLanguageSelector
componentavailable_content_localization_locales
ontoSiteSetting
so it's available in the service (without needing to parse the JSON to access it)📷 Screenshots