-
Notifications
You must be signed in to change notification settings - Fork 8.6k
FIX: latest duplicated groups to about components #33003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When "Add Groups to About" component is duplicated, choose the most recently updated settings for migration.
db/post_migrate/20250526063633_copy_add_groups_to_about_component_settings.rb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a concern but nothing blocking. Thank you for fixing this 👍
db/post_migrate/20250526063633_copy_add_groups_to_about_component_settings.rb
Show resolved
Hide resolved
1323633
to
9f293ce
Compare
@lis2 You may want to write a simple migration spec to test the logic in this migration as it doesn't seem to be that straightforward. |
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/update-error-copyaddgroupstoabout-componentsettings-sql/367696/8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
When "Add Groups to About" component is duplicated, choose the most recently updated settings for migration.
When "Add Groups to About" component is duplicated, choose the most recently updated settings for migration.