Skip to content

FIX: latest duplicated groups to about components #33003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

lis2
Copy link
Contributor

@lis2 lis2 commented May 30, 2025

When "Add Groups to About" component is duplicated, choose the most recently updated settings for migration.

When "Add Groups to About" component is duplicated, choose the most recently updated settings for migration.
Copy link
Contributor

@tgxworld tgxworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern but nothing blocking. Thank you for fixing this 👍

@tgxworld tgxworld self-requested a review May 30, 2025 06:27
@lis2 lis2 force-pushed the split-copy-add-group-migration branch from 1323633 to 9f293ce Compare May 30, 2025 07:33
@tgxworld
Copy link
Contributor

tgxworld commented Jun 2, 2025

@lis2 You may want to write a simple migration spec to test the logic in this migration as it doesn't seem to be that straightforward.

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/update-error-copyaddgroupstoabout-componentsettings-sql/367696/8

Copy link
Contributor

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lis2 lis2 merged commit 4e4ff41 into main Jun 4, 2025
16 checks passed
@lis2 lis2 deleted the split-copy-add-group-migration branch June 4, 2025 01:48
martin-brennan pushed a commit that referenced this pull request Jun 10, 2025
When "Add Groups to About" component is duplicated, choose the most
recently updated settings for migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants