FIX: when new new is enabled, filter dismiss modal to correct type #33037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megothss
pushed a commit
that referenced
this pull request
Jun 3, 2025
…33037) Currently both boxes are always checked, even if you're filtered to new topics or new posts. You must have the site setting `Experimental new new view groups` set to your user's group to see this mode.  This allows both options to appear, but only selects the current filter:  Turns out this was already implemented, but `subset` was always undefined. This fixes the arg and adds a couple new specs to cover it. see /t/155039 for reference
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
…33037) Currently both boxes are always checked, even if you're filtered to new topics or new posts. You must have the site setting `Experimental new new view groups` set to your user's group to see this mode.  This allows both options to appear, but only selects the current filter:  Turns out this was already implemented, but `subset` was always undefined. This fixes the arg and adds a couple new specs to cover it. see /t/155039 for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both boxes are always checked, even if you're filtered to new topics or new posts.
You must have the site setting
Experimental new new view groupsset to your user's group to see this mode.This allows both options to appear, but only selects the current filter:
Turns out this was already implemented, but
subsetwas always undefined. This fixes the arg and adds a couple new specs to cover it.see /t/155039 for reference