DEV: Add a ReviewableNote model, and tie it into the Reviewable model. #33047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/staff-review-queue-turning-a-flag-to-conversation/367337/13 |
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
tgxworld
reviewed
Jun 3, 2025
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
tgxworld
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
I think the ReviewablesController#index route suffers from a N+1 queries problem but I don't think it needs to block this PR.
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
#33047) As part of the review queue refresh, we'll be adding the ability for moderators to make notes on individual reviewable items. As a first step, this change adds the new model and associated backend code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's This?
As part of the review queue refresh, we'll be adding the ability for moderators to make notes on individual reviewable items. For example:
Since the feature will be tied into the UI refresh, this PR is solely focussed on adding the new model and associated backend code.