UX: only show single composer tip at a time #33050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
reviewed
Jun 3, 2025
app/assets/javascripts/discourse/app/components/composer-messages.gjs
Outdated
Show resolved
Hide resolved
d6cca37 to
58b0c49
Compare
CvX
approved these changes
Jun 5, 2025
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
Most composer tips use the "educational" template name but similar topics uses it's own template. We only allow showing if a tip using the template name wasn't shown already. So therefore a welcome message (ie. "educational") could show at the same time as a "similar topics" tip, which isn't ideal from a UX perspective. This change prevents overlapping composer tips by only opening the popup if there are no popups open already. Therefore requiring the user to close a tip before another different tip type could open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most composer tips use the "educational" template name but similar topics uses it's own template. We only allow showing if a tip using the template name wasn't shown already. So therefore a welcome message (ie. "educational") could show at the same time as a "similar topics" tip, which isn't ideal from a UX perspective.
This change prevents overlapping composer tips by only opening the popup if there are no popups open already. Therefore requiring the user to close a tip before another different tip type could open.