FIX: Respect category/tag filtering for reviewable webhooks #33051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
approved these changes
Jun 4, 2025
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
Currently, if you configure a webhook with reviewable events and apply categories/tags filtering, no webhook gets fired for reviewable events. This is because when we schedule the `EmitWebHookEvent` job, we don't pass to it the reviewable's category or tags, making it seem like the reviewable doesn't belong to the filtering category/tags that webhook specifies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you configure a webhook with reviewable events and apply categories/tags filtering, no webhook gets fired for reviewable events. This is because when we schedule the
EmitWebHookEventjob, we don't pass to it the reviewable's category or tags, making it seem like the reviewable doesn't belong to the filtering category/tags that webhook specifies.Internal topic: t/155369.