UX: rich editor [details] caret hover and padding #33057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato
commented
Jun 3, 2025
| @@ -6,7 +6,6 @@ const extension = { | |||
| attrs: { open: { default: true } }, | |||
| content: "summary block+", | |||
| group: "block", | |||
| draggable: true, | |||
There was a problem hiding this comment.
if draggable, it's harder to drag-select a text within any part of the details/summary, so I think removing it is a better default
|
Looks better, thanks |
jjaffeux
approved these changes
Jun 3, 2025
megothss
pushed a commit
that referenced
this pull request
Jun 3, 2025
Improves the styles for the [details] caret pseudo-element on the rich editor. Additionally, having `summary` have no `pointer-events` is important so Firefox doesn't mess with our caret positioning when clicking it.
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
Improves the styles for the [details] caret pseudo-element on the rich editor. Additionally, having `summary` have no `pointer-events` is important so Firefox doesn't mess with our caret positioning when clicking it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the styles for the [details] caret pseudo-element on the rich editor.
Additionally, having
summaryhave nopointer-eventsis important so Firefox doesn't mess with our caret positioning when clicking it.