FIX: Patches up potential for redirect loop #33061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cffbd11 to
c22e2ce
Compare
nullchristo
reviewed
Jun 4, 2025
nullchristo
reviewed
Jun 4, 2025
| @@ -14,6 +14,8 @@ const AuthErrors = [ | |||
| "awaiting_activation", | |||
| "admin_not_allowed_from_ip_address", | |||
| "not_allowed_from_ip_address", | |||
| "failed", | |||
There was a problem hiding this comment.
Looks like you don't end up needing to use failed/failed_reason
There was a problem hiding this comment.
I tossed it in at the end of the day so I didn't forget; do we want to hook them up for future-proofing?
nullchristo
reviewed
Jun 4, 2025
74b1a47 to
dd560f2
Compare
|
closing in favor of what @ZogStriP has drafted up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP