Skip to content

DEV: allow custom community sidebar links to pass models for route params #33070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

DEV: allow custom community sidebar links to pass models for route params #33070

merged 1 commit into from
Jun 6, 2025

Conversation

awesomerobot
Copy link
Member

Without this, you can't add a custom link like this...

api.addCommunitySectionLink({
 name: "tag-link",
 route: "tag.show",
 title: "foo",
 text: "bar",
 models: ["baz"]
})

...because the route needs a model

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/is-it-possible-to-pass-params-to-the-api-that-creates-community-links/368857/3

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/tag-intersection-navigator/368815/3

@awesomerobot awesomerobot merged commit 1cde45c into main Jun 6, 2025
17 checks passed
@awesomerobot awesomerobot deleted the dev-community-sidebar-models branch June 6, 2025 12:28
martin-brennan pushed a commit that referenced this pull request Jun 10, 2025
@awesomerobot @martin-brennan
DEV: allow custom community sidebar links to pass models for route pa…
887b263 
…rams (#33070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awesomerobot @discoursebot @CvX