UX: Adjust inconsistent spacing in search drop down #33074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awesomerobot
reviewed
Jun 4, 2025
| @@ -166,6 +168,7 @@ | |||
|
|
|||
| .search-link { | |||
| padding: var(--search-result-element-padding); | |||
| font-size: var(--font-down-1); | |||
There was a problem hiding this comment.
is making all of this stuff smaller intentional?
also the "more" link
| color: var(--primary-medium); | ||
|
|
||
| .tip-label { | ||
| background-color: rgb(var(--tertiary-rgb), 0.1); | ||
| margin-right: 0.25em; | ||
| padding: 2px 4px; | ||
| padding: 0 4px; |
There was a problem hiding this comment.
tips look off-center vertically to me now
before:
after:
| @@ -135,7 +138,6 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| border-radius: var(--d-border-radius); | |||
| padding-top: 0.75rem; | |||
There was a problem hiding this comment.
this removes the space above the first result... more consistent with the welcome banner, but also doesn't look quite as nice to me, but maybe that's just my opinion
after:
before:
it also means the loading state regresses to an earlier issue where we have no space below the input while loading (easier to see this locally if you throttle your connection):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the spacing consistent for different search states. Previously the hints box would increase in size when a term was entered into search.
I apply border styling to the correct stylesheet in order to have all versions of search dropdown retain consistent styling.
I also changed how padding is applied to keep it consistent.