FIX: Disallow encoded words in e-mail addresses #33083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the email validator to reject RFC 2047 encoded-word syntax in addresses, and adds a corresponding spec case.
- Add a negative check against encoded-word patterns in
valid_value? - Introduce
encoded_word_regexto detect=?charset?encoding?encoded-text?=fragments - Add a spec example for a
q-encoded word in the local part
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/lib/validators/email_address_validator_spec.rb | Add a test for a q-encoded word in the local part |
| lib/validators/email_address_validator.rb | Update valid_value? to reject encoded words and define its regex |
Comments suppressed due to low confidence (1)
spec/lib/validators/email_address_validator_spec.rb:19
- Only a lowercase
q-encoding is tested. Add cases for uppercaseQ, bothB/bencodings, and different charset names to ensure full RFC 2047 coverage.
"te=?utf-8?q?st?=@discourse.org"
|
@Drenmi I do think this should be under the |
d113193 to
4408123
Compare
4408123 to
d456569
Compare
tgxworld
reviewed
Jun 5, 2025
tgxworld
approved these changes
Jun 5, 2025
d456569 to
1fd6cd2
Compare
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
RFC 5322 allows special characters, including ? and =, to be used in e-mail addresses. RFC 2047 is an extension that adds a feature called "encoded words" which let you embed different encodings in the same header. However, it explicitly says that these aren't allowed in e-mail address headers. Encoded words have the format: encoded-word = "=?" charset "?" encoding "?" encoded-text "?=" Where encoding is either Q or B, but could take on other values in the future. After this change we consider e-mail addresses with an encoded word inside invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
RFC 5322 allows special characters, including
?and=, to be used in e-mail addresses.RFC 2047 is an extension that adds a feature called "encoded words" which let you embed different encodings in the same header. However, it explicitly says that these aren't allowed in e-mail address headers.
Encoded words have the format:
Where
encodingis eitherQorB, but could take on other values in the future.After this change we consider e-mail addresses with an encoded word inside invalid.