FIX: Allow setting blank secret on an existing webhook #33096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
commented
Jun 6, 2025
| @@ -42,7 +42,7 @@ export default class AdminConfigAreasWebhookForm extends Component { | |||
| return { | |||
| payload_url: this.webhook.payload_url, | |||
| content_type: this.webhook.content_type, | |||
| secret: this.webhook.secret === "" ? null : this.webhook.secret, | |||
There was a problem hiding this comment.
This was here because in previous versions of FormKit, validations (like length) would be applied to optional fields even if the field was blank. We needed to null it out to prevent that. That is fixed now.
jjaffeux
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
We had a regression where you can no longer update an existing webhook to have a blank secret field.
The problem is the blank field will return a value of
undefined, which is ignored by the store when sending the request to the back-end.This fixes that by using the nullish coalescing operator to replace
undefinedwith an empty string.In action: