FIX: Do not show header search icon if welcome banner search shown #33098
+55
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the search_icon header search mode to parity with the search_field mode. We don't want to show either of these if the welcome banner is showing, since it has a search field, this is redundant. If you scroll the page and the welcome banner is hidden, then we show the header search icon. This commit also cleans up some code related to the page-search shortcut, which we no longer use, including limiting showing search on topic only if there are > 20 posts.
martin-brennan
added a commit
to discourse/discourse-search-banner
that referenced
this pull request
Jun 6, 2025
With discourse/discourse#33098, you can no longer see the search button in the header if the welcome/search banner is shown, so we don't need to check for this.
nattsw
approved these changes
Jun 6, 2025
martin-brennan
added a commit
to discourse/discourse-search-banner
that referenced
this pull request
Jun 6, 2025
With discourse/discourse#33098, you can no longer see the search button in the header if the welcome/search banner is shown, so we don't need to check for this.
martin-brennan
added a commit
that referenced
this pull request
Jun 10, 2025
…33098) This brings the search_icon header search mode to parity with the search_field mode. We don't want to show either of these if the welcome banner is showing, since it has a search field, this is redundant. If you scroll the page and the welcome banner is hidden, then we show the header search icon. This commit also cleans up some code related to the page-search shortcut, which we no longer use, including limiting showing search on topic only if there are > 20 posts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the search_icon header search mode to parity with the
search_field mode. We don't want to show either of these if the welcome
banner is showing, since it has a search field, this is redundant.
If you scroll the page and the welcome banner is hidden, then we
show the header search icon.
This commit also cleans up some code related to the page-search
shortcut, which we no longer use, including limiting showing search
on topic only if there are > 20 posts.
Discourse-Tests.webm