DEV: Use canonical hostname for omniauth callbacks #33102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production, the enforce_hostname middleware overwrites the HTTP_HOST env using
Discourse.base_url_no_prefix
, which takes into account any configured protocol/hostname/post overrides.That middleware is not used in development, so if we want omniauth to respect any host/port overrides, we need to configure the 'full host' directly.