FIX: chat: if empty shows timer placeholder #33105
Merged
+31
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For empty chats, dummy message is still created with id=null (an unsaved Ember model). This change determines by existing id to show timer or placeholder.
jjaffeux
reviewed
Jun 6, 2025
jjaffeux
reviewed
Jun 6, 2025
plugins/chat/assets/javascripts/discourse/components/chat-channel-metadata.gjs
Outdated
Show resolved
Hide resolved
jjaffeux
reviewed
Jun 6, 2025
plugins/chat/assets/javascripts/discourse/components/chat-channel-metadata.gjs
Outdated
Show resolved
Hide resolved
|
If we go for simplicity, I will gladly use both suggestions: |
|
spec failure is unrelated |
jjaffeux
approved these changes
Jun 9, 2025
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
For empty chats, a dummy message is created with `id=null` (an unsaved Ember model). The timer or placeholder's display is determined by the message ID's presence now (not the `createdAt` prop).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For empty chats, dummy message is still created with
id=null(an unsaved Ember model).This change determines by existing
idto show timer or placeholder.