DEV: Improve quoted post handling and enhance decorator stability #33111
+182
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `topic` tracking to posts and improved quoted post handling by linking quoted posts to their parent topic. Introduced error handling for decorators to prevent crashes and ensure smoother operation in case of unexpected issues. These changes enhance reliability and data consistency across related components.
This commit introduces tests to ensure proper handling of nested quotes in the Glimmer Post Stream mode. It verifies that quote toggles expand and collapse correctly, including nested quotes within outer quotes. A new server fixture is also added to simulate the required post data for testing.
| // the application from crashing | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.error(e); |
There was a problem hiding this comment.
Can we make it throw in qunit/system-spec environments?
davidtaylorhq
approved these changes
Jun 10, 2025
In testing environments, re-throw errors from decorators for better visibility and debugging. In non-testing scenarios, log the errors to the console to avoid crashing the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
topictracking to posts and improved quoted post handling by linking quoted posts to their parent topic.Introduced error handling for decorators to prevent crashes and ensure smoother operation in case of unexpected issues.