DEV: Small fixes and tweaks in the Glimmer Post Stream #33112
+43
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `time-gap` component structure for improved semantics and consistency. Correct the date property reference in `post-stream` from `createdAt` to `created_at` to match the model property.
Ensure links with zero clicks do not render the "data-clicks" attribute when the value is zero. Added integration tests to verify correct handling of links with zero and non-zero click counts.
Updated button padding to use default values and removed the right margin for icons within topic posts. These changes ensure consistent spacing and alignment across the UI.
davidtaylorhq
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.