DEV: add valueTransformer customization points to flag.gjs #33113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markvanlan
reviewed
Jun 11, 2025
| // Provide an empty string as the default class, and pass post and component instance as context | ||
| return applyValueTransformer("flag-button-dynamic-class", "", { | ||
| post: this.args.post, | ||
| componentContext: this, |
There was a problem hiding this comment.
I don't think you're using componentContext in the sister PR for this, are you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds valueTransformers to the "Flag" button component:
flag-button-render-decision: whether to show the flag
flag-button-disabled-state: whether the flag button should be in a disabled state
post-action-menu__flag create-flag: ability to add class to flag button.
also adds "like-button-render-decision" valueTransformer to Like button, which determines whether to show or hide the like flag.