FIX: Add @enabled arg to <LoadMore /> component #33122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an @enabled boolean to `<LoadMore />` to allow for cases where the element is visible in the viewport but you don't want to allow the `loadMore` behaviour. A use case for this is when our controllers return some `canLoadMore` boolean. There is no use attempting to load more from the server in this case, there will be nothing else. I also moved the CSS styles for the `<LoadMore />` component into a new file. This also fixes a bug in the users list shown here https://meta.discourse.org/t/users-list-only-partial/368793
|
@tyb-talks can I please get a review on this one? |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/users-list-only-partial/368793/7 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-1pm-utc/291852/501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an @enabled boolean to
<LoadMore />to allow forcases where the element is visible in the viewport but you don't want to
allow the
loadMorebehaviour. A use case for this is when ourcontrollers return some
canLoadMoreboolean. There is no useattempting to load more from the server in this case, there will be
nothing else.
I also moved the CSS styles for the
<LoadMore />component intoa new file.
This also fixes a bug in the users list shown here
https://meta.discourse.org/t/users-list-only-partial/368793