DEV: Switch to type="module" for translation files
#33126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will be moving towards `type="module"` for all of Discourse's JS bundles in the near future. This commit makes a start by applying the change to translation bundles.
CvX
approved these changes
Jun 9, 2025
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
We will be moving towards `type="module"` for all of Discourse's JS bundles in the near future. This commit makes a start by applying the change to translation bundles. This was previously merged, but the lack of `apply_cdn_headers` on the locales controller led to CORS errors on sites with CDNs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be moving towards
type="module"for all of Discourse's JSbundles in the near future. This commit makes a start by applying the
change to translation bundles.
This was previously merged, but the lack of
apply_cdn_headerson the locales controller led to CORS errors on sites with CDNs.