Skip to content

FIX: Stop blocking auto scroll on iOS #33129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Conversation

nullchristo
Copy link
Contributor

Previously on iOS the chat would explicitly not scroll down to the bottom when a new message was added.

Looks like this check was originally added with some other changes in relation to some fixes avoiding a safari bug but as far as I can tell this doesn't re-introduce that bug.

Helps resolve this issue along with this discourse-livestream fix

Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out and keep an eye on iOS.

@nullchristo nullchristo merged commit b1f5d2e into main Jun 9, 2025
17 checks passed
@nullchristo nullchristo deleted the dev/chat-ios-autoscroll-fix branch June 9, 2025 20:00
martin-brennan pushed a commit that referenced this pull request Jun 10, 2025
Previously on iOS the chat would explicitly not scroll down to the bottom when a new message was added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat PRs which include a change to Chat plugin
Development

Successfully merging this pull request may close these issues.

2 participants