Skip to content

DEV: Improve quoted post handling and enhance decorator stability #33154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025

Conversation

megothss
Copy link
Contributor

No description provided.

megothss added 5 commits June 11, 2025 00:01
Added `topic` tracking to posts and improved quoted post handling by linking quoted posts to their parent topic. Introduced error handling for decorators to prevent crashes and ensure smoother operation in case of unexpected issues. These changes enhance reliability and data consistency across related components.
Stop tracking `topic` from the post model to prevent error while updating a post from another.

 Refactor post-related page objects to simplify method usage and add new helper methods. Improve post stream specs with enhanced context handling and support for glimmer settings to ensure robust testing of post interactions.
Changed the assignment to use Ember's `set` method for properly updating the `topic` property on `quotedPost`. This ensures data bindings or observers are triggered correctly if applicable.
The `topic` property is now tracked to ensure proper reactivity and prevent issues when handling null values. Adjusted logic to avoid overwriting `topic` with null if already initialized, and updated code in quote-controls to use direct property assignment instead of `set`.

before { sign_in(admin) }

it "can reply to a post and edit the reply" do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is to ensure we won't introduce the bug that broke the build again

@megothss megothss merged commit 5314b6a into main Jun 11, 2025
16 checks passed
@megothss megothss deleted the dev/fix-nexted-quoted-content branch June 11, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants