Skip to content

DEV: Add SKIP_DB_AND_REDIS bootability check to CI #33158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

davidtaylorhq
Copy link
Member

No description provided.

@davidtaylorhq davidtaylorhq marked this pull request as draft June 11, 2025 15:11
@davidtaylorhq davidtaylorhq marked this pull request as ready for review June 11, 2025 15:16
@davidtaylorhq davidtaylorhq merged commit 25f6984 into main Jun 11, 2025
15 checks passed
@davidtaylorhq davidtaylorhq deleted the check-bootability branch June 11, 2025 15:25
keegangeorge added a commit that referenced this pull request Jun 11, 2025
This is a second attempt at:
#33001

We had to [revert the
commit](#33157) because it
was performing a site-setting check at boot time, which is prone to
issues and not allowed.

This PR:
- re-introduces the changes in the original PR
- a fix by not performing a site-setting check at boot time (verified
by: `SKIP_DB_AND_REDIS=1 DISCOURSE_DEV_DB="nonexist" bin/rails runner
"puts 'booted'"` locally and should be caught by the new CI check
introduced here: #33158)
- adds a fix to the translation editor to not show the original post
locale in the dropdown, as well as adding an indicator of what the
original post locale is in a small badge in the header:
- ![Screenshot 2025-06-11 at 08 42
36](https://github.com/user-attachments/assets/5f0944c5-ec4d-40b3-b97f-25b1fcab8329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants