DEV: define CSS variables for button colors #33162
Open
+129
−101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds sets of CSS button variables that can be overridden in themes. This won't change any default styles, but just provides a less problematic method of customization.
The current suggested way of doing this is with SCSS like so:
The trouble with this is that it brings along all the btn mixin styles, so you also end up re-setting things like this, in addition to changing colors:
That can problematic because it can override existing button styles (e.g., if you already altered a single instance of margin). With these new CSS custom properties, you can avoid this by doing:
So now you can override the button colors without bringing along other styles from the btn mixin.
I also removed an old
.btn.hidden
style, as we already apply!important
to the.hidden
class elsewhere. Comments have also been updated to pass our new linting rules.