Skip to content

DEV: Improvements to post language selector #33178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

keegangeorge
Copy link
Member

@keegangeorge keegangeorge commented Jun 12, 2025

🔍 Overview

Sometimes users may overlook that there is a post translations selector when writing posts. This could lead to the site's default locale being used when a post is written in the user's preferred language.

This update ensures that:

  • the user's effective_locale is used as the default for the PostLanguageSelector in the composer
  • when the user's effective_locale is not one of the experimental_content_localization_supported_locales, we default to blank so that the post.locale doesn't get set
  • we also allow for setting a "none" option in the language selector for cases where the user wants to post in a language that is not part of experimental_content_localization_supported_locales

📷 Screenshots

Screenshot 2025-06-12 at 07 03 56

@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label Jun 12, 2025
@keegangeorge keegangeorge changed the title DEV: Add none value for post translations picker DEV: Update defaults for post language selector Jun 12, 2025
@keegangeorge keegangeorge changed the title DEV: Update defaults for post language selector DEV: Improvements to post language selector Jun 12, 2025
@keegangeorge keegangeorge marked this pull request as ready for review June 12, 2025 15:10
@keegangeorge keegangeorge merged commit 0607c47 into main Jun 12, 2025
31 of 32 checks passed
@keegangeorge keegangeorge deleted the post-translations-none-val branch June 12, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n PRs which update English locale files or i18n related code
Development

Successfully merging this pull request may close these issues.

2 participants