DEV: Refactor Chat::ListChannelThreadMessages a bit
#33380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7803ba to
bf0465d
Compare
bf0465d to
4867189
Compare
|
@dbattersby can you review this please? I think it's interesting to see how Loic refactors code. |
4867189 to
3d7459a
Compare
Flink
commented
Aug 7, 2025
| @@ -5,15 +5,19 @@ | |||
|
|
|||
| module DiscourseDev | |||
| class Thread < Record | |||
| def initialize(channel_id:, message_count: nil, ignore_current_count: false) | |||
| def initialize(channel_id:, count: nil, ignore_current_count: false) | |||
There was a problem hiding this comment.
It seems this whole class has been broken for quite some time 😅
Flink
commented
Aug 7, 2025
| def index | ||
| ::Chat::ListChannelThreadMessages.call( | ||
| service_params.deep_merge(params: { page_size: MAX_PAGE_SIZE }), |
There was a problem hiding this comment.
This was a bug as we were always forcing the page_size.
3d7459a to
32524dd
Compare
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/chat-api-page-size-parameter-is-ignored-when-direction-past/376984/5 |
jjaffeux
approved these changes
Aug 8, 2025
|
I’m not sure what’s best, tbh. It’s a slightly different approach, and we’re already returning an error for this case in https://github.com/discourse/discourse/blob/main/plugins/chat/app/services/chat/list_channel_messages.rb. We should stay consistent (one way or another). |
- Introduce a `max_page_size` option, allowing different behavior between controllers and SDK. - Improve the contract (validations & helper method). - Use `model` where possible. - Extract message existence logic to a dedicated policy, allowing easier testing. - Refactor specs to follow current guidelines/best practices.
32524dd to
a241a6d
Compare
pento
pushed a commit
that referenced
this pull request
Aug 11, 2025
- Introduce a `max_page_size` option, allowing different behavior between controllers and SDK. - Improve the contract (validations & helper method). - Use `model` where possible. - Extract message existence logic to a dedicated policy, allowing easier testing. - Refactor specs to follow current guidelines/best practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_page_sizeoption, allowing different behavior between controllers and SDK.modelwhere possible.