UX: Consistency and accessibility improvements for keyboard shortcuts #34090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f4f626 to
82e55b0
Compare
* Apply these rules to the display of all keyboard shortcuts in the app: * No shortcuts show a + between keys * On Windows and Linux, show Ctrl and Alt words, but show ⇧ for Shift * On macOS, show ⌃ for Control, ⌘ for Command, ⌥ for Option, and ⇧ for Shift * Use capital letters for the shortcut keys, e.g. Ctrl+S instead of Ctrl+s * Add a filter to the keyboard shortcut help modal to allow searching * Add aria-keyshortcuts attributes to the keyboard shortcuts in the composer toolbar and popup menu options
82e55b0 to
89f3228
Compare
renato
reviewed
Aug 6, 2025
app/assets/javascripts/discourse/app/components/modal/keyboard-shortcuts-help.gjs
Outdated
Show resolved
Hide resolved
renato
approved these changes
Aug 6, 2025
|
I know it's not from your PR, but "Return to composer" with a Shift C... no idea what that is 🤔 |
…-shortcuts-help.gjs Co-authored-by: Renato Atilio <renato@discourse.org>
|
Ah @renato it focuses the composer input, but it doesn't work for rich editor because of this hardcoded selector :) discourse/app/assets/javascripts/discourse/app/services/composer.js Lines 607 to 613 in 8cc7d14 Will fix this up |
…se/discourse into ux/keyboard-shortcut-consistency
yuriyaran
pushed a commit
that referenced
this pull request
Aug 21, 2025
…#34090) * Apply these rules to the display of all keyboard shortcuts in the app: * No shortcuts show a + between keys * On Windows and Linux, show Ctrl and Alt words, but show ⇧ for Shift * On macOS, show ⌃ for Control, ⌘ for Command, ⌥ for Option, and ⇧ for Shift * Use capital letters for the shortcut keys, e.g. Ctrl+S instead of Ctrl+s * Add a filter to the keyboard shortcut help modal to allow searching * Add aria-keyshortcuts attributes to the keyboard shortcuts in the composer toolbar and popup menu options * Adds Ctrl+Enter + Esc shortcuts for composer --------- Co-authored-by: Renato Atilio <renato@discourse.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolbar and popup menu options