DEV: Unify reviewable action definition. #34166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7f7db9 to
dfd2a3c
Compare
tgxworld
reviewed
Aug 11, 2025
tgxworld
reviewed
Aug 11, 2025
tgxworld
reviewed
Aug 11, 2025
tgxworld
reviewed
Aug 11, 2025
tgxworld
reviewed
Aug 11, 2025
tgxworld
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's This?
This is a step towards unifying how reviewable types are defined.
In this PR, we add a new
ReviewableActionBuilderconcern, which can be included by the various reviewable types to give them a standard helper for adding actions that can be performed on the reviewable.The first feature for this concern takes the
build_action()helper that some reviewables used, and makes it available to all reviewables. This is done in a backward compatible fashion, so it will work even whilst we transition to the new reviewable UI.