FIX: improve color input hex autocomplete #34218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
approved these changes
Aug 12, 2025
app/assets/javascripts/discourse/tests/integration/components/color-input-test.gjs
Outdated
Show resolved
Hide resolved
…color-input-test.gjs Co-authored-by: Jarek Radosz <jradosz@gmail.com>
dbattersby
added a commit
that referenced
this pull request
Aug 13, 2025
This change allows users to update category text color without autocompleting the input value. Instead we are using `onBlur` to allow the normalized hex value to be updated when the using submits or tabs/clicks out of the field. We are also restoring the normalized hex back to the correct value - for example`f8f` becomes `ff88ff` if using only 3 digits. This was mistakenly changed in #34218 to improve auto complete in the edit category page but it affects the color pickers in other parts of the app too. --------- Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color input component autocompletes hex patterns to update 3 character codes to 6 characters. However we should only attempt to format common patterns, and don't intervene for non sequenced values. For example, we can:
eeetoeeeeeef2ftof2f2f20f8and allow the user to complete manually