Skip to content

UX: set horizon as the default theme for new sites #34229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renato
Copy link
Contributor

@renato renato commented Aug 11, 2025

No description provided.

@@ -365,7 +365,7 @@ basic:
hidden: true
client: true
default_theme_id:
default: -1
default: -2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting if you look at the history, this wasn't recent from the Foundation change...we did it as a "no value" placeholder for default_theme_id :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change this line here as well:

Theme.foundation_theme.set_default!

You can do Theme.horizon_theme

Copy link
Contributor

@martin-brennan martin-brennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; personally I would also test this locally on a fresh db with the DISCOURSE_DEV_DB env var, just to be sure you end up with the correct theme when the site migrates/boots

Also make sure you update the other place I commented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants