FIX: Allow themes index to resort when adding new themes #34314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows the same pattern as the color palette index, where we sort the themes once, and then resort only when the themes array from the model changes. This fixes the issue where if you installed a new theme, it would not show up on the grid until you refreshed.
martin-brennan
commented
Aug 14, 2025
| <template> | ||
| <span {{didUpdate this.resetSortedThemes @themes}}></span> |
There was a problem hiding this comment.
I don't like this...but didUpdate will not work if I put it on AdminFilterControls
There was a problem hiding this comment.
all this logic… sounds like a job for @cached decorator? 👀
There was a problem hiding this comment.
This works partially, but still doesn't address the original issue, which is that we didn't want the default theme to jump around in the list when you change it:
There was a problem hiding this comment.
Actually...I just saw that we reload the whole page now when we change the default theme, so it doesn't matter anyway 🤦 Will just use cached
CvX
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the same pattern as the color palette index, where we
sort the themes once, and then resort only when the themes array
from the model changes. This fixes the issue where if you installed
a new theme, it would not show up on the grid until you refreshed.