FIX: Link to correct staff action logs for theme site setting #34315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where the history link on hover for a theme site setting would point to the staff action logs for regular site settings, not the theme site setting ones which include the theme name in the subject and also have a different `change_theme_site_setting` action. c.f. https://meta.discourse.org/t/link-to-change-history-on-themeable-site-settings/377394
|
Test fail is flaky |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/link-to-change-history-on-themeable-site-settings/377394/4 |
yuriyaran
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the history link on hover for a theme site setting
would point to the staff action logs for regular site settings, not the
theme site setting ones which include the theme name in the subject
and also have a different
change_theme_site_settingaction.c.f. https://meta.discourse.org/t/link-to-change-history-on-themeable-site-settings/377394
This icon
Linking here