UX: Use rotate icon for convert theme button #34317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, no icon is set for the button when the theme being displayed is not a theme component. That made the UI inconsistent since all the surrounding action buttons has an icon. Previously, a cube was used for a theme component but we don't see how that makes sense anymore. Upon clicking the button, there is a confirmation dialog that indicates to the user whether we are converting the curren theme to a component or not.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/missing-cube-icon-in-the-convert-button-on-themes/378072/5 |
tyb-talks
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, no icon is set for the button when the theme being
displayed is not a theme component. That made the UI inconsistent since
all the surrounding action buttons has an icon. Previously, a cube was
used for a theme component but we don't see how that makes sense
anymore.
Upon clicking the button, there is a confirmation dialog that indicates
to the user whether we are converting the curren theme to a component or
not.
Screenshot